Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: src/debug.cc

Issue 3164018: Fix breakpoints on inlined named stores in code from the optimizing compiler (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/cctest/test-debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 443 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 // the inlined case to always go through the IC. As long as the break point 454 // the inlined case to always go through the IC. As long as the break point
455 // is set the patching performed by the runtime system will take place in 455 // is set the patching performed by the runtime system will take place in
456 // the code copy and will therefore have no effect on the running code 456 // the code copy and will therefore have no effect on the running code
457 // keeping it from using the inlined code. 457 // keeping it from using the inlined code.
458 if (code->is_keyed_load_stub()) { 458 if (code->is_keyed_load_stub()) {
459 KeyedLoadIC::ClearInlinedVersion(pc()); 459 KeyedLoadIC::ClearInlinedVersion(pc());
460 } else if (code->is_keyed_store_stub()) { 460 } else if (code->is_keyed_store_stub()) {
461 KeyedStoreIC::ClearInlinedVersion(pc()); 461 KeyedStoreIC::ClearInlinedVersion(pc());
462 } else if (code->is_load_stub()) { 462 } else if (code->is_load_stub()) {
463 LoadIC::ClearInlinedVersion(pc()); 463 LoadIC::ClearInlinedVersion(pc());
464 } else if (code->is_store_stub()) {
465 StoreIC::ClearInlinedVersion(pc());
464 } 466 }
465 } 467 }
466 } 468 }
467 469
468 470
469 void BreakLocationIterator::ClearDebugBreakAtIC() { 471 void BreakLocationIterator::ClearDebugBreakAtIC() {
470 // Patch the code to the original invoke. 472 // Patch the code to the original invoke.
471 rinfo()->set_target_address(original_rinfo()->target_address()); 473 rinfo()->set_target_address(original_rinfo()->target_address());
472 474
473 RelocInfo::Mode mode = rmode(); 475 RelocInfo::Mode mode = rmode();
(...skipping 2569 matching lines...) Expand 10 before | Expand all | Expand 10 after
3043 { 3045 {
3044 Locker locker; 3046 Locker locker;
3045 Debugger::CallMessageDispatchHandler(); 3047 Debugger::CallMessageDispatchHandler();
3046 } 3048 }
3047 } 3049 }
3048 } 3050 }
3049 3051
3050 #endif // ENABLE_DEBUGGER_SUPPORT 3052 #endif // ENABLE_DEBUGGER_SUPPORT
3051 3053
3052 } } // namespace v8::internal 3054 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/cctest/test-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698