Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1326)

Issue 3164008: Use generate_test_report to generate the run_remote_test report (Closed)

Created:
10 years, 4 months ago by kmixter1
Modified:
9 years, 7 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://git@chromiumos-git//crosutils.git
Visibility:
Public.

Description

Use generate_test_report to generate the run_remote_test report. BUG=5359

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -17 lines) Patch
M run_remote_tests.sh View 1 chunk +2 lines, -17 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
kmixter1
10 years, 4 months ago (2010-08-11 22:45:07 UTC) #1
petkov
LGTM http://codereview.chromium.org/3164008/diff/1/2 File run_remote_tests.sh (right): http://codereview.chromium.org/3164008/diff/1/2#newcode287 run_remote_tests.sh:287: $(dirname "$0")/generate_test_report "${TMP}" you could use --prefix to ...
10 years, 4 months ago (2010-08-11 22:49:50 UTC) #2
kmixter1
10 years, 4 months ago (2010-08-12 00:47:33 UTC) #3
pushed... did use prefix.

On Wed, Aug 11, 2010 at 3:49 PM,  <petkov@chromium.org> wrote:
> LGTM
>
>
>
> http://codereview.chromium.org/3164008/diff/1/2
> File run_remote_tests.sh (right):
>
> http://codereview.chromium.org/3164008/diff/1/2#newcode287
> run_remote_tests.sh:287: $(dirname "$0")/generate_test_report "${TMP}"
> you could use --prefix to make the output somewhat nicer, maybe...
> showing the full path certainly has its advantages though.
>
> http://codereview.chromium.org/3164008/show
>

Powered by Google App Engine
This is Rietveld 408576698