Issue 3163034: revive power_Backlight test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3163034: revive power_Backlight test (Closed)

Created:
10 years, 4 months ago by tbroch1

Modified:
9 years, 7 months ago

Reviewers:
davidjames, ericli, Sameer Nanda

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org

Base URL:
http://src.chromium.org/git/autotest.git

Visibility:
Public.

Description

revive power_Backlight test BUG=chromium-os:5616 TEST=manual Change-Id: Ie0ebef2672cfa06393f571597e801694cc1316fa

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	client/site_tests/power_Backlight/power_Backlight.py	View		3 chunks	+4 lines, -6 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sameer Nanda

10 years, 4 months ago (2010-08-25 20:48:48 UTC) #3

Thanks for looking into this!

http://codereview.chromium.org/3163034/diff/1/2
File client/site_tests/power_Backlight/power_Backlight.py (right):

http://codereview.chromium.org/3163034/diff/1/2#newcode25
client/site_tests/power_Backlight/power_Backlight.py:25:
site_ui.xsystem('LD_LIBRARY_PATH=/usr/local/lib ' + 'xset -dpms')
The three xset calls can be taken out now since powerd has now taken over this
functionality. Just stopping powerd is sufficient now.

In fact, the entire block above including the 5 sec sleep and the comments above
it can now be nuked.

Expand Messages | Collapse Messages