Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 3163028: Fix compilation errors of 56862 (Closed)

Created:
10 years, 4 months ago by andreip3000
Modified:
9 years, 6 months ago
Reviewers:
TVL, jorlow
CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Fix compilation errors of 56862 by - making the include path lower case in renderer_webidbransaction_impl.cc, - adding a newline at the end of indexed_db_dispatcher.cc - fixing the initialization order of member variables in indexed_db_callbacks.h Revert "Revert 56862 - Add transaction coordinator. Allow idle transactions to be aborted when their parent JS context finishes executing." This reverts commit 6b25a433481c9127f8dbcbadc7f0685dc643d6de. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57042

Patch Set 1 #

Patch Set 2 : Fix include path (again) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -4 lines) Patch
M chrome/browser/in_process_webkit/indexed_db_callbacks.h View 2 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h View 6 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 14 chunks +92 lines, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/common/render_messages_internal.h View 4 chunks +24 lines, -0 lines 0 comments Download
M chrome/renderer/indexed_db_dispatcher.h View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/renderer/indexed_db_dispatcher.cc View 3 chunks +15 lines, -0 lines 0 comments Download
M chrome/renderer/renderer_webidbdatabase_impl.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/renderer/renderer_webidbdatabase_impl.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/renderer/renderer_webidbfactory_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/renderer/renderer_webidbfactory_impl.cc View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/renderer/renderer_webidbtransaction_impl.h View 1 chunk +33 lines, -0 lines 0 comments Download
A chrome/renderer/renderer_webidbtransaction_impl.cc View 1 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
andreip3000
Thomas, Jeremy, can you please have a look before I resubmit? Thanks
10 years, 4 months ago (2010-08-20 16:40:55 UTC) #1
jorlow
10 years, 4 months ago (2010-08-20 16:44:01 UTC) #2
Eh...it's just one character

LGTM

On Fri, Aug 20, 2010 at 5:40 PM, <andreip@chromium.org> wrote:

> Reviewers: TVL, jorlow,
>
> Message:
> Thomas, Jeremy, can you please have a look before I resubmit? Thanks
>
> Description:
> Fix compilation errors of 56862 by
>
> - making the include path lower case in renderer_webidbransaction_impl.cc,
> - adding a newline at the end of indexed_db_dispatcher.cc
> - fixing the initialization order of member variables in
> indexed_db_callbacks.h
>
> Revert "Revert 56862 - Add transaction coordinator. Allow idle transactions
> to
> be aborted when their parent JS context finishes executing."
>
> This reverts commit 6b25a433481c9127f8dbcbadc7f0685dc643d6de.
>
> Please review this at http://codereview.chromium.org/3163028/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
>  M chrome/browser/in_process_webkit/indexed_db_callbacks.h
>  M chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
>  M chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
>  M chrome/chrome_renderer.gypi
>  M chrome/common/render_messages_internal.h
>  M chrome/renderer/indexed_db_dispatcher.h
>  M chrome/renderer/indexed_db_dispatcher.cc
>  M chrome/renderer/renderer_webidbdatabase_impl.h
>  M chrome/renderer/renderer_webidbdatabase_impl.cc
>  M chrome/renderer/renderer_webidbfactory_impl.h
>  M chrome/renderer/renderer_webidbfactory_impl.cc
>  A chrome/renderer/renderer_webidbtransaction_impl.h
>  A chrome/renderer/renderer_webidbtransaction_impl.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698