Issue 3163027: A quick fix for Bug 52808....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3163027: A quick fix for Bug 52808.... (Closed)

Created:
10 years, 4 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr., jochen (gone - plz use gerrit)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A quick fix for Bug 52808. This change just creates a scoped_ptr<Value> variable and sets the return value of base::JSONReader::Read() to it. BUG=52808 TEST=make the "Linux Test (valgrind)(1)" bot green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56831

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/host_content_settings_map_unittest.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

10 years, 4 months ago (2010-08-20 08:29:19 UTC) #2

Thanks for getting on this. LGTM with a nit:

http://codereview.chromium.org/3163027/diff/1/2
File chrome/browser/host_content_settings_map_unittest.cc (right):

http://codereview.chromium.org/3163027/diff/1/2#newcode591
chrome/browser/host_content_settings_map_unittest.cc:591:
profile.GetPrefs()->Set(prefs::kContentSettingsPatterns, *value.get());
Nit: I think you can just use *value here.

Expand Messages | Collapse Messages