Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3841)

Unified Diff: chrome/browser/views/toolbar_view.h

Issue 3163023: Clean up the WrenchMenuModel so that it uses SimpleMenu::Delegate. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Fix stray rb Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/views/toolbar_view.h
diff --git a/chrome/browser/views/toolbar_view.h b/chrome/browser/views/toolbar_view.h
index af73d607b4995c12378f4c185bb14b04023bbc4c..08550c0717eddbd6bd25b2329e3fae94d5cc6e0a 100644
--- a/chrome/browser/views/toolbar_view.h
+++ b/chrome/browser/views/toolbar_view.h
@@ -8,7 +8,7 @@
#include <vector>
-#include "app/menus/simple_menu_model.h"
+#include "app/menus/accelerator.h"
#include "app/slide_animation.h"
#include "base/scoped_ptr.h"
#include "chrome/browser/back_forward_menu_model.h"
@@ -27,11 +27,12 @@ class BrowserActionsContainer;
class Browser;
class Profile;
class WrenchMenu;
+class WrenchMenuModel;
// The Browser Window's toolbar.
class ToolbarView : public AccessibleToolbarView,
public views::ViewMenuDelegate,
- public menus::SimpleMenuModel::Delegate,
+ public menus::AcceleratorProvider,
public LocationBarView::Delegate,
public AnimationDelegate,
public NotificationObserver,
@@ -104,12 +105,9 @@ class ToolbarView : public AccessibleToolbarView,
const NotificationSource& source,
const NotificationDetails& details);
- // Overridden from menus::SimpleMenuModel::Delegate:
- virtual bool IsCommandIdChecked(int command_id) const;
- virtual bool IsCommandIdEnabled(int command_id) const;
+ // Overridden from menus::AcceleratorProvider:
virtual bool GetAcceleratorForCommandId(int command_id,
menus::Accelerator* accelerator);
- virtual void ExecuteCommand(int command_id);
// Overridden from views::View:
virtual gfx::Size GetPreferredSize();
@@ -185,7 +183,7 @@ class ToolbarView : public AccessibleToolbarView,
DisplayMode display_mode_;
// The contents of the app menu.
- scoped_ptr<menus::SimpleMenuModel> app_menu_model_;
+ scoped_ptr<WrenchMenuModel> wrench_menu_model_;
// Wrench menu.
scoped_ptr<WrenchMenu> wrench_menu_;

Powered by Google App Engine
This is Rietveld 408576698