Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Unified Diff: chrome/browser/cocoa/wrench_menu_controller.h

Issue 3163023: Clean up the WrenchMenuModel so that it uses SimpleMenu::Delegate. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Fix stray rb Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/wrench_menu_controller.h
diff --git a/chrome/browser/cocoa/wrench_menu_controller.h b/chrome/browser/cocoa/wrench_menu_controller.h
index 99f37438333361fdca5aa583f2d0e747ac94799e..65d32fc949bccb9155ded5ffa8733ada8901afaf 100644
--- a/chrome/browser/cocoa/wrench_menu_controller.h
+++ b/chrome/browser/cocoa/wrench_menu_controller.h
@@ -40,12 +40,16 @@ class ZoomLevelObserver;
IBOutlet NSButton* zoomMinus_;
IBOutlet NSButton* zoomFullScreen_;
+ WrenchMenuModel* wrench_model_;
Robert Sesek 2010/08/24 00:31:13 Unnecessary. The MenuController already maintains
Robert Sesek 2010/08/24 15:28:07 Name this wrenchMenuModel_ and add a comment as to
+
scoped_ptr<WrenchMenuControllerInternal::ZoomLevelObserver> observer_;
}
Robert Sesek 2010/08/24 15:28:07 Add: @property (nonatomic, assign) WrenchMenuModel
// Designated initializer; called within the NIB.
- (id)init;
+- (void)setWrenchMenuModel:(WrenchMenuModel*)model;
Robert Sesek 2010/08/24 00:31:13 Remove.
Robert Sesek 2010/08/24 15:28:07 Still remove this proto.
+
// Used to dispatch commands from the Wrench menu. The custom items within the
// menu cannot be hooked up directly to First Responder because the window in
// which the controls reside is not the BrowserWindowController, but a
@@ -55,9 +59,6 @@ class ZoomLevelObserver;
// Returns the weak reference to the WrenchMenuModel.
- (WrenchMenuModel*)wrenchMenuModel;
-// Inserts the update available notification menu item.
-- (void)insertUpdateAvailableItem;
-
@end
////////////////////////////////////////////////////////////////////////////////

Powered by Google App Engine
This is Rietveld 408576698