Fix DictionaryValue::Equals() to also detect differences in key names.

base/values.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/values.h"
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 
@@ skipping 321 matching lines @@
   if (other->GetType() != GetType())
     return false;
 
   const DictionaryValue* other_dict =
       static_cast<const DictionaryValue*>(other);
   key_iterator lhs_it(begin_keys());
   key_iterator rhs_it(other_dict->begin_keys());
   while (lhs_it != end_keys() && rhs_it != other_dict->end_keys()) {
     Value* lhs;
     Value* rhs;
-    if (!GetWithoutPathExpansion(*lhs_it, &lhs) ||
+    if (*lhs_it != *rhs_it ||
+        !GetWithoutPathExpansion(*lhs_it, &lhs) ||
         !other_dict->GetWithoutPathExpansion(*rhs_it, &rhs) ||
         !lhs->Equals(rhs)) {
       return false;
     }
     ++lhs_it;
     ++rhs_it;
   }
   if (lhs_it != end_keys() || rhs_it != other_dict->end_keys())
     return false;
 
@@ skipping 677 matching lines @@
       return false;
   }
   if (lhs_it != end() || rhs_it != other_list->end())
     return false;
 
   return true;
 }
 
 ValueSerializer::~ValueSerializer() {
 }