Issue 3163020: Fix DictionaryValue::Equals() to also detect differences in key names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3163020: Fix DictionaryValue::Equals() to also detect differences in key names. (Closed)

Created:
10 years, 4 months ago by Mattias Nissler (ping if slow)

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Fix DictionaryValue::Equals() to also detect differences in key names. BUG=52419 TEST=unit tests in values_unittest.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56536

Patch Set 1 #

Patch Set 2 : fix test expectations #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -15 lines)			Patch
M	base/values.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	base/values_unittest.cc	View	1 chunk	+13 lines, -6 lines	0 comments	Download
M	chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mattias Nissler (ping if slow)

Hi Tony, here's a small fix for you to review.

10 years, 4 months ago (2010-08-17 13:04:55 UTC) #1

Mattias Nissler (ping if slow)

10 years, 4 months ago (2010-08-17 17:55:21 UTC) #3

On 2010/08/17 16:58:46, tony wrote:
> Wow, good catch.  LGTM!

Turns out we even have a broken test that went unnoticed due to the bug. I've
updated the data files, speak up if you're not OK with committing these.

Expand Messages | Collapse Messages