Issue 3162034: Avoid spawning a thread while enabling the OOM killer on the Mac....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3162034: Avoid spawning a thread while enabling the OOM killer on the Mac.... (Closed)

Created:
10 years, 4 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Avoid spawning a thread while enabling the OOM killer on the Mac. BUG=53200 TEST=n/a Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57218

Patch Set 1 #

Total comments: 4

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -7 lines)			Patch
	M	base/process_util_mac.mm	View		4 chunks	+14 lines, -7 lines	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM http://codereview.chromium.org/3162034/diff/1/2 File base/process_util_mac.mm (right): http://codereview.chromium.org/3162034/diff/1/2#newcode627 base/process_util_mac.mm:627: long darwin_version = strtol(machine_info.release, (char**)NULL, 10); Do you ...

10 years, 4 months ago (2010-08-24 15:13:24 UTC) #2

Avi (use Gerrit)

10 years, 4 months ago (2010-08-24 15:16:36 UTC) #3

http://codereview.chromium.org/3162034/diff/1/2
File base/process_util_mac.mm (right):

http://codereview.chromium.org/3162034/diff/1/2#newcode627
base/process_util_mac.mm:627: long darwin_version = strtol(machine_info.release,
(char**)NULL, 10);
On 2010/08/24 15:13:24, Mark Mentovai wrote:
> Do you really need this cast?

No. Done.

http://codereview.chromium.org/3162034/diff/1/2#newcode762
base/process_util_mac.mm:762: (darwin_version == 9) || (darwin_version == 10);
On 2010/08/24 15:13:24, Mark Mentovai wrote:
> The parentheses aren’t necessary and I don’t think they make anything clearer.
> 
> The old code had |os_minor == 5 || os_minor == 6|, seems the same as just
> writing |darwin_version == 9 || darwin_version == 10|.

Done.

Expand Messages | Collapse Messages