Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 3162028: Fix a dumb error introduced earlier. We need to call Stop only when the wait ... (Closed)

Created:
10 years, 4 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Fix a dumb error introduced earlier. We need to call Stop only when the wait on the python server returns an error TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome_frame/test/http_server.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
10 years, 4 months ago (2010-08-20 19:25:39 UTC) #1
amit
10 years, 4 months ago (2010-08-20 20:01:49 UTC) #2
ok

On Fri, Aug 20, 2010 at 12:25 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Fix a dumb error introduced earlier. We need to call Stop only when the
> wait on
> the python server
> returns an error
>
> TBR=amit
>
>
> Please review this at http://codereview.chromium.org/3162028/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/http_server.cc
>
>
> Index: chrome_frame/test/http_server.cc
> ===================================================================
> --- chrome_frame/test/http_server.cc    (revision 56883)
> +++ chrome_frame/test/http_server.cc    (working copy)
> @@ -67,7 +67,6 @@
>   bool ret = test_server_.WaitToFinish(milliseconds);
>   if (!ret) {
>     LOG(ERROR) << "WaitToFinish failed with error:" << ::GetLastError();
> -  } else {
>     ret = test_server_.Stop();
>   }
>   return ret;
>
>
>

Powered by Google App Engine
This is Rietveld 408576698