Issue 3162026: Heapchecker: Widen a suppression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3162026: Heapchecker: Widen a suppression. (Closed)

Created:
10 years, 4 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
TVL, viettrungluu

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Heapchecker: Widen a suppression. BUG=38293 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56895

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	tools/heapcheck/suppressions.txt	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

TVL

lg with nit http://codereview.chromium.org/3162026/diff/1/2 File tools/heapcheck/suppressions.txt (left): http://codereview.chromium.org/3162026/diff/1/2#oldcode290 tools/heapcheck/suppressions.txt:290: keep this blank line?

10 years, 4 months ago (2010-08-20 18:34:01 UTC) #2

viettrungluu

However you change/widen this suppression is fine with me. LGTM. http://codereview.chromium.org/3162026/diff/1/2 File tools/heapcheck/suppressions.txt (left): http://codereview.chromium.org/3162026/diff/1/2#oldcode287 ...

10 years, 4 months ago (2010-08-20 18:35:08 UTC) #3

Lei Zhang

10 years, 4 months ago (2010-08-20 18:37:54 UTC) #4

http://codereview.chromium.org/3162026/diff/1/2
File tools/heapcheck/suppressions.txt (left):

http://codereview.chromium.org/3162026/diff/1/2#oldcode287
tools/heapcheck/suppressions.txt:287: fun:BookmarkModel::AddURL
On 2010/08/20 18:35:08, viettrungluu wrote:
> You might be able to get away with just deleting one of these lines. (This
> suppression isn't currently used, at least on the run which failed.)

Sure.

http://codereview.chromium.org/3162026/diff/1/2#oldcode290
tools/heapcheck/suppressions.txt:290: 
On 2010/08/20 18:34:01, TVL wrote:
> keep this blank line?

Done. I don't know who started adding all these blank lines. We don't do it for
memcheck.

Expand Messages | Collapse Messages

Issue 3162026: Heapchecker: Widen a suppression. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages