Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 3162025: Add the reverse test to EnvironmentTest. (Closed)

Created:
10 years, 4 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.
Base URL:
git://git.chromium.org/chromium.git
Visibility:
Public.

Description

Add the reverse test to EnvironmentTest. This test basically test another behavior of the GetVar function. It tries to get a variable by looking for its reverse form. BUG=None TEST=out/Debug/base_unittests --gtest_filter=EnvironmentTest.GetVarReverse. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56950

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M base/environment_unittest.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
10 years, 4 months ago (2010-08-20 03:20:27 UTC) #1
Lei Zhang
http://codereview.chromium.org/3162025/diff/1/2 File base/environment_unittest.cc (right): http://codereview.chromium.org/3162025/diff/1/2#newcode32 base/environment_unittest.cc:32: EXPECT_NE(env_value, ""); Do you need both of these tests? ...
10 years, 4 months ago (2010-08-20 03:55:16 UTC) #2
tfarina
http://codereview.chromium.org/3162025/diff/1/2 File base/environment_unittest.cc (right): http://codereview.chromium.org/3162025/diff/1/2#newcode32 base/environment_unittest.cc:32: EXPECT_NE(env_value, ""); On 2010/08/20 03:55:16, Lei Zhang wrote: > ...
10 years, 4 months ago (2010-08-20 04:01:47 UTC) #3
tfarina
http://codereview.chromium.org/3162025/diff/1/2 File base/environment_unittest.cc (right): http://codereview.chromium.org/3162025/diff/1/2#newcode32 base/environment_unittest.cc:32: EXPECT_NE(env_value, ""); On 2010/08/20 03:55:16, Lei Zhang wrote: > ...
10 years, 4 months ago (2010-08-20 04:01:47 UTC) #4
Lei Zhang
10 years, 4 months ago (2010-08-20 04:49:11 UTC) #5
LGTM!

Powered by Google App Engine
This is Rietveld 408576698