Issue 3162008: 10.6 SDK compatibility fix for GradientButtonCell following r55906

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3162008: 10.6 SDK compatibility fix for GradientButtonCell following r55906 (Closed)

Created:
10 years, 4 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
Bons

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

10.6 SDK compatibility fix for GradientButtonCell following r55906. See r26348, "Avoid spurious errors about NSColor*-CGColor* and NSSize-CGSize conversions": The SDK has gotten stupider in 10.6, and has conspired with the compiler, which now thinks that when the receiver is held in a scoped_nsobject, NSColor and NSSize arguments should be converted to their CG cousins. BUG=51430 TEST=10.6 SDK build (mac_sdk=10.6) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55949

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/cocoa/gradient_button_cell.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages