Issue 3161041: AU: Support redirects.

Issue 3161041: AU: Support redirects. (Closed)

Created:
10 years, 4 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

AU: Support redirects. BUG=5692 TEST=unit tests, gmerged on device, making sure update engine still works Change-Id: If593f6efbd39452aa98b453f4d5489ce7d7d7fb9

Patch Set 4 : review comments #

Patch Set 5 : reorder headers again #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -7 lines)			Patch
M	http_fetcher_unittest.cc	View	1 2 3 4	2 chunks	+93 lines, -3 lines	0 comments	Download
M	libcurl_http_fetcher.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	libcurl_http_fetcher.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	test_http_server.cc	View	1 2	7 chunks	+54 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

The number 10 is kind of random -- let me know if you have any ...

10 years, 4 months ago (2010-08-24 22:52:55 UTC) #1

adlr

LGTM w/ nits http://codereview.chromium.org/3161041/diff/4001/5001 File http_fetcher_unittest.cc (right): http://codereview.chromium.org/3161041/diff/4001/5001#newcode5 http_fetcher_unittest.cc:5: #include <glib.h> i guess i considered ...

10 years, 4 months ago (2010-08-25 19:41:10 UTC) #2

petkov

10 years, 4 months ago (2010-08-25 20:00:16 UTC) #3

http://codereview.chromium.org/3161041/diff/4001/5001
File http_fetcher_unittest.cc (right):

http://codereview.chromium.org/3161041/diff/4001/5001#newcode5
http_fetcher_unittest.cc:5: #include <glib.h>
On 2010/08/25 19:41:10, adlr wrote:
> i guess i considered glib to be a library. the order specified in the style
> guide is:
> 
> 
> dir2/foo2.h (preferred location — see details below).
> C system files.
> C++ system files.
> Other libraries' .h files.
> Your project's .h files.

Moved to a separate section. I'm not sure what other library header files means
vs project headers. Is project headers just "update_engine"? If so, we would
need to regroup other header includes too.

http://codereview.chromium.org/3161041/diff/4001/5001#newcode476
http_fetcher_unittest.cc:476: void RedirectTest(bool expected_successful,
On 2010/08/25 19:41:10, adlr wrote:
> make a comment that this takes ownership of http_fetcher

Done.

Expand Messages | Collapse Messages