Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Unified Diff: chrome/browser/browser.h

Issue 3161037: Remove attempt to be smart about where to open navigations (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: wherps Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser.h
diff --git a/chrome/browser/browser.h b/chrome/browser/browser.h
index 4c99238de84acb2eabd2a9a4ad98bbbf3113eaee..5f9a23c41acbe3281fa9abe5537a8bbab1de7a30 100644
--- a/chrome/browser/browser.h
+++ b/chrome/browser/browser.h
@@ -621,7 +621,6 @@ class Browser : public TabStripModelDelegate,
virtual void TabRestoreServiceDestroyed(TabRestoreService* service);
private:
- FRIEND_TEST_ALL_PREFIXES(BrowserTest, PinnedTabDisposition);
FRIEND_TEST_ALL_PREFIXES(BrowserTest, NoTabsInPopups);
// Used to describe why a tab is being detached. This is used by
@@ -637,8 +636,6 @@ class Browser : public TabStripModelDelegate,
DETACH_TYPE_EMPTY
};
- bool IsPinned(TabContents* source);
-
// Overridden from TabStripModelDelegate:
virtual TabContents* AddBlankTab(bool foreground);
virtual TabContents* AddBlankTabAt(int index, bool foreground);
@@ -950,17 +947,6 @@ class Browser : public TabStripModelDelegate,
// cancel closing of window.
bool IsClosingPermitted();
- // Calculate a new window open disposition for a navigation. The return
- // value will usually be |original_disposition|, but for some pinned tab cases
- // we change it to NEW_FOREGROUND_TAB so that the pinned tab feels more
- // permanent.
- static WindowOpenDisposition AdjustWindowOpenDispositionForTab(
- bool is_pinned,
- const GURL& url,
- const GURL& referrer,
- PageTransition::Type transition,
- WindowOpenDisposition original_disposition);
-
// Data members /////////////////////////////////////////////////////////////
NotificationRegistrar registrar_;
« no previous file with comments | « no previous file | chrome/browser/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698