Remove attempt to be smart about where to open navigations

chrome/browser/extensions/extension_dom_ui.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_dom_ui.h"
 
 #include <set>
 
 #include "net/base/file_stream.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/chrome_thread.h"
 #include "chrome/browser/extensions/extension_bookmark_manager_api.h"
 #include "chrome/browser/extensions/extensions_service.h"
 #include "chrome/browser/extensions/image_loading_tracker.h"
 #include "chrome/browser/pref_service.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/renderer_host/render_widget_host_view.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/common/bindings_policy.h"
 #include "chrome/common/page_transition_types.h"
 #include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/extension_resource.h"
 #include "chrome/common/url_constants.h"
 #include "gfx/codec/png_codec.h"
 #include "gfx/favicon_size.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 
 namespace {
 
 // De-dupes the items in |list|. Assumes the values are strings.
 void CleanUpDuplicates(ListValue* list) {
@@ skipping 101 matching lines @@
   // Use the NavigationController to get the URL rather than the TabContents
   // since this is the real underlying URL (see HandleChromeURLOverride).
   NavigationController& controller = tab_contents()->controller();
   const GURL& url = controller.GetActiveEntry()->url();
   extension_function_dispatcher_.reset(
       ExtensionFunctionDispatcher::Create(render_view_host, this, url));
   DCHECK(extension_function_dispatcher_.get());
 }
 
 void ExtensionDOMUI::ResetExtensionBookmarkManagerEventRouter() {
-  extension_bookmark_manager_event_router_.reset(
-      new ExtensionBookmarkManagerEventRouter(GetProfile(), tab_contents()));
-  // We set the link transition type to AUTO_BOOKMARK for the bookmark manager.
-  // This doesn't really belong here, but neither does this function.
-  // ExtensionDOMUI could potentially be used for extensions besides the
-  // bookmark manager, but currently it does not.
-  link_transition_type_ = PageTransition::AUTO_BOOKMARK;
+  // Hack: A few things we specialize just for the bookmark manager.
+  if (extension_function_dispatcher_->extension_id() ==
+      extension_misc::kBookmarkManagerId) {
+    extension_bookmark_manager_event_router_.reset(
+        new ExtensionBookmarkManagerEventRouter(GetProfile(), tab_contents()));
+
+    link_transition_type_ = PageTransition::AUTO_BOOKMARK;
+  }
 }
 
 void ExtensionDOMUI::RenderViewCreated(RenderViewHost* render_view_host) {
   ResetExtensionFunctionDispatcher(render_view_host);
   ResetExtensionBookmarkManagerEventRouter();
 }
 
 void ExtensionDOMUI::RenderViewReused(RenderViewHost* render_view_host) {
   ResetExtensionFunctionDispatcher(render_view_host);
   ResetExtensionBookmarkManagerEventRouter();
@@ skipping 210 matching lines @@
 }
 
 // static
 void ExtensionDOMUI::GetFaviconForURL(Profile* profile,
     FaviconService::GetFaviconRequest* request, const GURL& page_url) {
   // tracker deletes itself when done.
   ExtensionDOMUIImageLoadingTracker* tracker =
       new ExtensionDOMUIImageLoadingTracker(profile, request, page_url);
   tracker->Init();
 }