Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 3161034: Rename (Host|Client)Message to Chromoting(Host|Client)Message. (Closed)

Created:
10 years, 4 months ago by garykac
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Sergey Ulanov, dmac, awong, garykac, Paweł Hajdan Jr.
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Rename (Host|Client)Message to Chromoting(Host|Client)Message. Rename HostMessage and ClientMessage to Chromoting{Host|Client}Message to avoid conflicts with messages in X11. Actually, only ClientMessage needs to be changed due to conflict, but HostMessage is changed to keep the names consistent. BUG=none TEST=remoting unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57112 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57255

Patch Set 1 #

Patch Set 2 : Fix merge conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -97 lines) Patch
M remoting/base/codec_test.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M remoting/base/decoder.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M remoting/base/decoder_verbatim.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/base/decoder_verbatim.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M remoting/base/decoder_verbatim_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/decoder_zlib.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/base/decoder_zlib.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M remoting/base/encoder.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/base/encoder_verbatim.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/encoder_zlib.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/base/encoder_zlib.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M remoting/base/protocol/chromotocol.proto View 1 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/base/protocol_decoder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/base/protocol_decoder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/base/protocol_decoder_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/client/chromoting_client.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/client/chromoting_client.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M remoting/client/chromoting_view.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/client/plugin/pepper_view.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/client/plugin/pepper_view.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M remoting/client/x11_input_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/x11_view.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/client/x11_view.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/client_connection.h View 2 chunks +7 lines, -7 lines 0 comments Download
M remoting/host/client_connection.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/event_executor_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/session_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/session_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/session_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
garykac
10 years, 4 months ago (2010-08-20 03:29:35 UTC) #1
Alpha Left Google
LGTM.
10 years, 4 months ago (2010-08-20 05:18:24 UTC) #2
Alpha Left Google
On 2010/08/20 05:18:24, Alpha wrote: > LGTM. Since this patch was reverted, should let this ...
10 years, 4 months ago (2010-08-24 21:34:38 UTC) #3
Timur Iskhodzhanov
10 years, 4 months ago (2010-08-25 13:22:48 UTC) #4
After this CL the suppressed memory leak has stopped matching the Valgrind
suppression, see
http://code.google.com/p/chromium/issues/detail?id=46678

On 2010/08/24 21:34:38, Alpha wrote:
> On 2010/08/20 05:18:24, Alpha wrote:
> > LGTM.
> 
> Since this patch was reverted, should let this be closed and start a new CL
> review.

Powered by Google App Engine
This is Rietveld 408576698