Issue 3161018: Get rid of the deprecated file_util::InsertBeforeExtension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3161018: Get rid of the deprecated file_util::InsertBeforeExtension. (Closed)

Created:
10 years, 4 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Description

Get rid of the deprecated file_util::InsertBeforeExtension. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56477

Patch Set 1 #

Total comments: 2

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -66 lines)			Patch
	M	base/file_util_deprecated.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	base/file_util_unittest.cc	View		1 chunk	+0 lines, -63 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

http://codereview.chromium.org/3161018/diff/1/3 File base/file_util_unittest.cc (left): http://codereview.chromium.org/3161018/diff/1/3#oldcode290 base/file_util_unittest.cc:290: {FPL("/bar/baz/foo.exe"), FPL(" (1)"), FPL("/bar/baz/foo (1).exe")}, Is it worth porting ...

10 years, 4 months ago (2010-08-17 19:13:56 UTC) #2

tfarina

10 years, 4 months ago (2010-08-17 19:39:45 UTC) #3

LGTM!

Expand Messages | Collapse Messages