Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 316016: Move the json-related files into a separate json directory. This hopefully al... (Closed)

Created:
11 years, 2 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
dhg
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ncarter (slow), ben+cc_chromium.org, Erik does not do reviews, idana, jam, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review), tim (not reviewing)
Visibility:
Public.

Description

Move the json-related files into a separate json directory. This hopefully also makes the naming of string_escape more clear (it's actually JSON-specific). Move the files into the base namespace. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29934

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -2053 lines) Patch
M base/base.gyp View 1 2 4 chunks +9 lines, -9 lines 0 comments Download
A + base/json/json_reader.h View 4 chunks +8 lines, -4 lines 0 comments Download
A + base/json/json_reader.cc View 3 chunks +5 lines, -1 line 0 comments Download
A + base/json/json_reader_unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download
A + base/json/json_writer.h View 3 chunks +7 lines, -3 lines 0 comments Download
A + base/json/json_writer.cc View 4 chunks +9 lines, -9 lines 0 comments Download
A + base/json/json_writer_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
A + base/json/string_escape.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + base/json/string_escape.cc View 3 chunks +7 lines, -3 lines 0 comments Download
A + base/json/string_escape_unittest.cc View 1 5 chunks +14 lines, -10 lines 0 comments Download
D base/json_reader.h View 1 2 1 chunk +0 lines, -186 lines 0 comments Download
D base/json_reader.cc View 1 2 1 chunk +0 lines, -638 lines 0 comments Download
D base/json_reader_unittest.cc View 1 2 1 chunk +0 lines, -516 lines 0 comments Download
D base/json_writer.h View 1 2 1 chunk +0 lines, -55 lines 0 comments Download
D base/json_writer.cc View 1 2 1 chunk +0 lines, -198 lines 0 comments Download
D base/json_writer_unittest.cc View 1 2 1 chunk +0 lines, -77 lines 0 comments Download
D base/string_escape.h View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
D base/string_escape.cc View 1 2 1 chunk +0 lines, -87 lines 0 comments Download
D base/string_escape_unittest.cc View 1 2 1 chunk +0 lines, -95 lines 0 comments Download
M chrome/browser/automation/automation_extension_function.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/extension_port_container.cc View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_storage.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/debugger/debugger_remote_service.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/debugger/devtools_remote_service.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/debugger/extension_ports_remote_service.cc View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui.cc View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_page_sync_handler.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_browser_event_router.cc View 1 2 12 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_function.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_toolstrip_api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_uitest.cc View 1 2 6 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extensions_service_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/starred_url_database.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sync_setup_flow.cc View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/sync_setup_wizard_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/json_value_serializer.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/json_value_serializer_unittest.cc View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/sandbox_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/web_resource/web_resource_unpacker.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/dom_ui_bindings.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/extension_api_client_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/extension_process_bindings.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/ui_test_utils.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M net/base/net_util.cc View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M net/base/strict_transport_security_state.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
11 years, 2 months ago (2009-10-22 21:32:55 UTC) #1
dhg
Looks like its failing on mac?
11 years, 2 months ago (2009-10-22 23:51:54 UTC) #2
brettw
New snap up with Mac file added.
11 years, 2 months ago (2009-10-23 16:48:58 UTC) #3
dhg
11 years, 2 months ago (2009-10-23 19:56:45 UTC) #4 
On 2009/10/23 16:48:58, brettw wrote:
> New snap up with Mac file added.

LGTM

Powered by Google App Engine
This is Rietveld 408576698