Loading local resources uses improved fallback algorithm....

Loading local resources uses improved fallback algorithm.

Before:
 _locales/current_locale/rel_path, then extension root/rel_path

Now:
 _locales/{current_locale, parents}/rel_path, then extension root/rel_path

This change syncs local resource loading with catalog loading algo.

BUG=12131
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29815

[Nebojša Ćirić, 2009-10-22 18:34:10]

Adding mad@google.com just in case (I don't think there are any new dependencies
in the code).

[Aaron Boodman, 2009-10-22 18:51:37]

lgtm

http://codereview.chromium.org/316013/diff/1/3
File chrome/browser/extensions/extension_l10n_util.cc (right):

http://codereview.chromium.org/316013/diff/1/3#newcode186
Line 186: void GetL10nRelativePath(const FilePath& relative_resource_path,
This function now returns a list, not a single item. Its name should change to
indicate this.

http://codereview.chromium.org/316013/diff/1/3#newcode188
Line 188: if (!l10n_paths)
Why would a caller ever pass NULL? Should this be a DCHECK?

[Nebojša Ćirić, 2009-10-22 20:04:51]

Added DCHECK just in case. All done, submitting.

On 2009/10/22 18:51:37, Aaron Boodman wrote:
> lgtm
> 
> http://codereview.chromium.org/316013/diff/1/3
> File chrome/browser/extensions/extension_l10n_util.cc (right):
> 
> http://codereview.chromium.org/316013/diff/1/3#newcode186
> Line 186: void GetL10nRelativePath(const FilePath& relative_resource_path,
> This function now returns a list, not a single item. Its name should change to
> indicate this.
> 
> http://codereview.chromium.org/316013/diff/1/3#newcode188
> Line 188: if (!l10n_paths)
> Why would a caller ever pass NULL? Should this be a DCHECK?