Add fucomip instruction to disassembler.

Add fucomip instruction to disassembler.  Fix some other floating point instructions.

Committed: http://code.google.com/p/v8/source/detail?r=3141

[Lasse Reichstein, 2009-10-23 07:39:52]

LGTM

[Lasse Reichstein, 2009-10-27 09:01:40]

Still LGTM.

http://codereview.chromium.org/316010/diff/9002/6004
File src/x64/disasm-x64.cc (right):

http://codereview.chromium.org/316010/diff/9002/6004#newcode661
Line 661: assert(*data == 0xF7 || *data == 0xF6);
Shouldn't this be ASSERT? (I.e., using our own ASSERT, not the C++ assert.h
library).

http://codereview.chromium.org/316010/diff/9002/6004#newcode811
Line 811: ASSERT((escape_opcode & 0xF8) == 0xD8);
Use ASSERT_EQ (or switch to assert to be consistent).

http://codereview.chromium.org/316010/diff/9002/6004#newcode932
Line 932: case 0xD8: mnem = "fstp"; break;
Do we have a "fst" implementation?

http://codereview.chromium.org/316010/diff/9002/6004#newcode1067
Line 1067: ASSERT((*current & 0xC0) != 0xC0);
ASSERT_NE

[William Hesse, 2009-10-27 10:47:56]

http://codereview.chromium.org/316010/diff/9002/6004
File src/x64/disasm-x64.cc (right):

http://codereview.chromium.org/316010/diff/9002/6004#newcode661
Line 661: assert(*data == 0xF7 || *data == 0xF6);
On 2009/10/27 09:01:40, Lasse Reichstein wrote:
> Shouldn't this be ASSERT? (I.e., using our own ASSERT, not the C++ assert.h
> library).

All asserts changed to ASSERT_EQ, ASSERT_NE, or ASSERT in both files.

http://codereview.chromium.org/316010/diff/9002/6004#newcode932
Line 932: case 0xD8: mnem = "fstp"; break;
On 2009/10/27 09:01:40, Lasse Reichstein wrote:
> Do we have a "fst" implementation?

That's a big "affirmative", partner.