Issue 316008: Make WebSocketStreamHandleBridge RefCountedThreadSafe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 316008: Make WebSocketStreamHandleBridge RefCountedThreadSafe. (Closed)

Created:
11 years, 2 months ago by ukai

Modified:
9 years, 7 months ago

Reviewers:
tyoshino (SeeGerritForStatus), Yuzo

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make WebSocketStreamHandleBridge RefCountedThreadSafe. In layout_tests, test_shell crashed by /base/ref_counted.cc(60)] Check failed: in_dtor_. RefCountedThreadSafe object deleted without calling Release() in context of test_shell(webkit_glue::WebSocketStreamHandleImpl::Context::DidClose(WebKit::WebSocketStreamHandle*)+0x7d) [0x8f6b34b] Since bridge instance is ref counted object, we must not delete it. Make base class WebSocketStreamHandleBridge RefCountedThreadSafe, and manage it by scoped_refptr. BUG=25399 TEST=layout tests not crashed in XHR tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29769

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -11 lines)			Patch
M	webkit/glue/websocketstreamhandle_bridge.h	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	webkit/glue/websocketstreamhandle_impl.cc	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	webkit/tools/test_shell/simple_socket_stream_bridge.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ukai

didn't crash in layout_tests http://build.chromium.org/buildbot/try-server/builders/layout_linux/builds/349/steps/webkit_tests/logs/stdio

11 years, 2 months ago (2009-10-22 11:32:03 UTC) #2

LGTM

Expand Messages | Collapse Messages