Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 3160007: Merge 65090 - 2010-08-10 Abhishek Arya <inferno@chromium.org>... (Closed)

Created:
10 years, 4 months ago by inferno
Modified:
9 years, 7 months ago
Reviewers:
inferno
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 65090 - 2010-08-10 Abhishek Arya <inferno@chromium.org>; Reviewed by David Hyatt. Take checks for ruby base existence out of the ASSERTs. https://bugs.webkit.org/show_bug.cgi?id=43795 Test: fast/ruby/ruby-remove-no-base.html * rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::addChild): (WebCore::RenderRubyRun::removeChild): 2010-08-10 Abhishek Arya <inferno@chromium.org>; Reviewed by David Hyatt. Tests that removing a ruby child which causes merging of ruby base withe a non existant base of the right sibling run does not result in crash. https://bugs.webkit.org/show_bug.cgi?id=43795 * fast/ruby/ruby-remove-no-base-expected.txt: Added. * fast/ruby/ruby-remove-no-base.html: Added. BUG=51654 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -15 lines) Patch
A LayoutTests/fast/ruby/ruby-remove-no-base.html View 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/fast/ruby/ruby-remove-no-base-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M WebCore/rendering/RenderRubyRun.cpp View 2 chunks +17 lines, -15 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
inferno
10 years, 4 months ago (2010-08-12 14:11:01 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698