Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issue 3160006: Preserve constant function transition when adding the same function. (Closed)

Created:
10 years, 4 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Preserve constant function transition when adding the same function. This should help in cases like: function Constructor() { this.foo = constFunction; this.bar = "baz"; } for (...) { o = new Constructor(); // Constant call IC will work. o.foo(); // Inlined property load will see the same map. use(o.bar); } This change also fixes a latent bug in custom call IC-s for strings exposed by string-charcodeat.js. Committed: http://code.google.com/p/v8/source/detail?r=5254

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -14 lines) Patch
M src/ia32/stub-cache-ia32.cc View 4 chunks +8 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.cc View 5 chunks +24 lines, -11 lines 0 comments Download
M src/objects-inl.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/property.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vitaly Repeshko
10 years, 4 months ago (2010-08-12 13:26:57 UTC) #1
Vitaly Repeshko
Adding antonm who co-authored this change. -- Vitaly
10 years, 4 months ago (2010-08-12 13:29:08 UTC) #2
Mads Ager (chromium)
10 years, 4 months ago (2010-08-12 13:41:57 UTC) #3
LGTM!

Powered by Google App Engine
This is Rietveld 408576698