Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 3159045: Fix a crash when delegate_ goes away in ReadStream... (Closed)

Created:
10 years, 4 months ago by amit
Modified:
9 years ago
Reviewers:
stoyan
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Fix a crash when delegate_ goes away in ReadStream Other callbacks can fire in the context of ReadStream and OnStopBinding might happen in that context. In this case the delegate_ is cleaned up and this results in a crash when ReadStream returns. BUG=53460 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57581

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome_frame/urlmon_url_request.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
amit
10 years, 4 months ago (2010-08-26 17:09:16 UTC) #1
stoyan
10 years, 4 months ago (2010-08-26 17:51:02 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698