AutoFill doesn't fill address information on www.gorillaclothing.com

AutoFill doesn't fill address information on www.gorillaclothing.com

Adjusts address heuristics to match "addressLine1" and "addressLine2" names.  Also, cleans up the regular expressions to avoid redundancies.

BUG=52126
TEST=FormStructureTest.BillingAndShippingAddresses

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57610

[James Hawkins, 2010-08-26 01:01:47]

http://codereview.chromium.org/3159043/diff/1/2
File chrome/browser/autofill/address_field.cc (left):

http://codereview.chromium.org/3159043/diff/1/2#oldcode205
chrome/browser/autofill/address_field.cc:205: ASCIIToUTF16("street|address
line|address1|street_line1|addr1");
I'd prefer if we kept the list explicit.  The heuristics are unstable enough as
is.

[dhollowa, 2010-08-26 01:16:27]

http://codereview.chromium.org/3159043/diff/1/2
File chrome/browser/autofill/address_field.cc (left):

http://codereview.chromium.org/3159043/diff/1/2#oldcode205
chrome/browser/autofill/address_field.cc:205: ASCIIToUTF16("street|address
line|address1|street_line1|addr1");
On 2010/08/26 01:01:47, James Hawkins wrote:
> I'd prefer if we kept the list explicit.  The heuristics are unstable enough
as
> is.

Not quite sure what you mean by unstable.  From what I've seen, the majority of
bugs come from under-matching.  That's why I opened things up a bit.

How about this for a counter proposal:

  "address.?line|address1|addr1|street" ?

[James Hawkins, 2010-08-26 20:50:07]

http://codereview.chromium.org/3159043/diff/1/2
File chrome/browser/autofill/address_field.cc (left):

http://codereview.chromium.org/3159043/diff/1/2#oldcode205
chrome/browser/autofill/address_field.cc:205: ASCIIToUTF16("street|address
line|address1|street_line1|addr1");
On 2010/08/26 01:16:27, dhollowa wrote:
> On 2010/08/26 01:01:47, James Hawkins wrote:
> > I'd prefer if we kept the list explicit.  The heuristics are unstable enough
> as
> > is.
> 
> Not quite sure what you mean by unstable.  From what I've seen, the majority
of
> bugs come from under-matching.  That's why I opened things up a bit.
> 
> How about this for a counter proposal:
> 
>   "address.?line|address1|addr1|street" ?
> 

OK, same goes for the change below.

[dhollowa, 2010-08-26 22:25:22]

http://codereview.chromium.org/3159043/diff/1/2
File chrome/browser/autofill/address_field.cc (left):

http://codereview.chromium.org/3159043/diff/1/2#oldcode205
chrome/browser/autofill/address_field.cc:205: ASCIIToUTF16("street|address
line|address1|street_line1|addr1");
On 2010/08/26 20:50:08, James Hawkins wrote:
> On 2010/08/26 01:16:27, dhollowa wrote:
> > On 2010/08/26 01:01:47, James Hawkins wrote:
> > > I'd prefer if we kept the list explicit.  The heuristics are unstable
enough
> > as
> > > is.
> > 
> > Not quite sure what you mean by unstable.  From what I've seen, the majority
> of
> > bugs come from under-matching.  That's why I opened things up a bit.
> > 
> > How about this for a counter proposal:
> > 
> >   "address.?line|address1|addr1|street" ?
> > 
> 
> OK, same goes for the change below.

Done.  Expect small additions once my other patch lands.

[James Hawkins, 2010-08-26 22:31:09]

LGTM

[dhollowa, 2010-08-26 23:25:43]

Merged from trunk.