Issue 3159012: Merge 55939 - Fix chrome frame upgrade from old to new beta. During upgrade p...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3159012: Merge 55939 - Fix chrome frame upgrade from old to new beta. During upgrade p... (Closed)

Created:
10 years, 4 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
ananta

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/branches/472/src/

Visibility:
Public.

Description

Merge 55939 - Fix chrome frame upgrade from old to new beta. During upgrade process, two versions of chrome frame may get loaded in IE at the same time. We have code to fallback to the old version in case this happens. However a small overight in declaring a local variable twice in different scopes led to these checks to fail. BUG=51620 TEST=test upgrade from 5.0.375.125 to 6.0.472.XXX while IE is running and try 'Open in New window' etc.. Review URL: http://codereview.chromium.org/3136009 TBR=ananta@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55941

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	chrome_frame/module_utils.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages