Issue 3159010: Don't throw an error if not on stabilizing branch and give more information on exit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3159010: Don't throw an error if not on stabilizing branch and give more information on exit. (Closed)

Created:
10 years, 4 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://src.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Don't throw an error if not on stabilizing branch and give more information on exit. TEST=Ran "cros_mark_as_stable push" with no stabilizing_branch

Patch Set 2 : petkov #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	cros_mark_as_stable.py	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

LGTM w/ a suggestion. http://codereview.chromium.org/3159010/diff/1/2 File cros_mark_as_stable.py (right): http://codereview.chromium.org/3159010/diff/1/2#newcode129 cros_mark_as_stable.py:129: print 'No work found to ...

10 years, 4 months ago (2010-08-12 17:29:13 UTC) #2

good point, will do and commit

Expand Messages | Collapse Messages

Issue 3159010: Don't throw an error if not on stabilizing branch and give more information on exit. (Closed)

Description

Patch Set 1 #

Patch Set 2 : petkov #

Messages