Issue 3158023: OOBE screen with HTML page specified from command line it is going to be used for recovery screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3158023: OOBE screen with HTML page specified from command line it is going to be used for recovery screen. (Closed)

Created:
10 years, 4 months ago by Dmitry Polukhin

Modified:
9 years, 7 months ago

Reviewers:
dr

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

OOBE screen with HTML page specified from command line it is going to be used for recovery screen. BUG=chromium-os:5877 TEST=Run Chrome with --login-manager --login-screen=html file://filename Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56836

Patch Set 1 #

Patch Set 2 : Fixed issue with empty arguments in command line #

Total comments: 2

Patch Set 3 : Removed useless explicit #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+240 lines, -0 lines)			Patch
A	chrome/browser/chromeos/login/html_page_screen.h	View	1 2	1 chunk	+82 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/login/html_page_screen.cc	View	1	1 chunk	+123 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.h	View		5 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.cc	View	1 2	5 chunks	+28 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM http://codereview.chromium.org/3158023/diff/2001/3002 File chrome/browser/chromeos/login/html_page_screen.h (right): http://codereview.chromium.org/3158023/diff/2001/3002#newcode54 chrome/browser/chromeos/login/html_page_screen.h:54: explicit HTMLPageScreen(WizardScreenDelegate* delegate, explicit is required only for ...

10 years, 4 months ago (2010-08-19 18:41:49 UTC) #2

Dmitry Polukhin

10 years, 4 months ago (2010-08-20 09:40:28 UTC) #3

http://codereview.chromium.org/3158023/diff/2001/3002
File chrome/browser/chromeos/login/html_page_screen.h (right):

http://codereview.chromium.org/3158023/diff/2001/3002#newcode54
chrome/browser/chromeos/login/html_page_screen.h:54: explicit
HTMLPageScreen(WizardScreenDelegate* delegate,
On 2010/08/19 18:41:49, dr wrote:
> explicit is required only for single-argument constructors?

Yes, I forgot to remove it when added second param.

Expand Messages | Collapse Messages