Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 3158003: Update xpdual/moz/total_byte_r. (Closed)

Created:
10 years, 4 months ago by chase
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Update xpdual/moz/total_byte_r. Looks like this result can be flaky, so give it a new delta and var to keep the step green most of the time. BUG=none TEST=xpdual/moz is green TBR=nsylvain@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf_expectations/perf_expectations.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
chase
10 years, 4 months ago (2010-08-10 21:29:50 UTC) #1
Nicolas Sylvain
10 years, 4 months ago (2010-08-11 01:55:06 UTC) #2
lgtm

On Tue, Aug 10, 2010 at 2:29 PM, <chase@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Description:
> Update xpdual/moz/total_byte_r.
>
> Looks like this result can be flaky, so give it a new
> delta and var to keep the step green most of the time.
>
> BUG=none
> TEST=xpdual/moz is green
> TBR=nsylvain@chromium.org
>
> Please review this at http://codereview.chromium.org/3158003/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
>  M tools/perf_expectations/perf_expectations.json
>
>
> Index: tools/perf_expectations/perf_expectations.json
> diff --git a/tools/perf_expectations/perf_expectations.json
> b/tools/perf_expectations/perf_expectations.json
> index
>
13899b31a177ab4942efefb724b9ea295fa7c311..ecfb9227bed7463b7ea867d69f35cd3f5ae96cbc
> 100644
> --- a/tools/perf_expectations/perf_expectations.json
> +++ b/tools/perf_expectations/perf_expectations.json
> @@ -42,7 +42,7 @@
>  "xp-release-dual-core/morejs/times/t": {"delta": -120, "var": 16},
>  "xp-release-dual-core/moz/times/t": {"delta": 20, "var": 20},
>  "xp-release-dual-core/moz/total_byte_b/IO_b": {"delta": 540, "var": 100},
> - "xp-release-dual-core/moz/total_byte_r/IO_r": {"delta": 260, "var": 55},
> + "xp-release-dual-core/moz/total_byte_r/IO_r": {"delta": 310, "var": 80},
>  "xp-release-dual-core/moz/total_op_b/IO_op_b": {"delta": -4250, "var":
> 350},
>  "xp-release-dual-core/moz/total_op_r/IO_op_r": {"delta": 535, "var": 590},
>  "xp-release-dual-core/moz/vm_peak_b/vm_pk_b": {"delta": 1050000, "var":
> 80000},
>
>
>

Powered by Google App Engine
This is Rietveld 408576698