cros_workon - Issue 3157044: cros_workon: make --board and --host not exclusive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cros_workon

Issue 3157044: cros_workon: make --board and --host not exclusive (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cros_workon

diff --git a/cros_workon b/cros_workon

index 1a9626b1f661b35ff723042509ff57d8ddc1c09f..128933a84a540d971db8302fe5a5d4d17043592a 100755

--- a/cros_workon

+++ b/cros_workon

@@ -45,9 +45,13 @@ WORKON_CMD=$1

shift

-# board dir config

+# Board dir config

+# If both are specified, just use host, because board does not

+# have to be specified and may come from default, in which case

+# there's no way to override.

[ -n "${FLAGS_board}" ] && [ "${FLAGS_host}" = ${FLAGS_TRUE} ] && \

- die "Flags --host and --board are mutually exclusive."

+ FLAGS_board="" # kill board

Mandeep Singh Baines 2010/08/27 01:47:01 I'm uncomfortable with modifying a shflags paramet

[ -z "${FLAGS_board}" ] && [ "${FLAGS_host}" = ${FLAGS_FALSE} ] && \

die "You must specify either --host or --board="

« no previous file with comments | « no previous file | no next file » | no next file with comments »