Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: cros_workon

Issue 3157044: cros_workon: make --board and --host not exclusive (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cros_workon
diff --git a/cros_workon b/cros_workon
index 1a9626b1f661b35ff723042509ff57d8ddc1c09f..128933a84a540d971db8302fe5a5d4d17043592a 100755
--- a/cros_workon
+++ b/cros_workon
@@ -45,9 +45,13 @@ WORKON_CMD=$1
shift
-# board dir config
+# Board dir config
+
+# If both are specified, just use host, because board does not
+# have to be specified and may come from default, in which case
+# there's no way to override.
[ -n "${FLAGS_board}" ] && [ "${FLAGS_host}" = ${FLAGS_TRUE} ] && \
- die "Flags --host and --board are mutually exclusive."
+ FLAGS_board="" # kill board
Mandeep Singh Baines 2010/08/27 01:47:01 I'm uncomfortable with modifying a shflags paramet
[ -z "${FLAGS_board}" ] && [ "${FLAGS_host}" = ${FLAGS_FALSE} ] && \
die "You must specify either --host or --board="
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698