DOMUI: Add the basic HTML for the 'Edit Address' AutoFill overlay.

DOMUI: Add the basic HTML for the 'Edit Address' AutoFill overlay.

BUG=49094
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56785

[dhg, 2010-08-18 22:44:07]

http://codereview.chromium.org/3157027/diff/3001/4002
File chrome/browser/dom_ui/add_startup_page_handler.h (right):

http://codereview.chromium.org/3157027/diff/3001/4002#newcode10
chrome/browser/dom_ui/add_startup_page_handler.h:10: #include
"base/basictypes.h"
I'm not clear as to why this needed to be moved to the header

http://codereview.chromium.org/3157027/diff/3001/4007
File chrome/browser/resources/options/add_startup_page_overlay.js (right):

http://codereview.chromium.org/3157027/diff/3001/4007#newcode129
chrome/browser/resources/options/add_startup_page_overlay.js:129: });
This file should probably just be reverted.

http://codereview.chromium.org/3157027/diff/3001/4009
File chrome/browser/resources/options/autofill_edit_address_overlay.html
(right):

http://codereview.chromium.org/3157027/diff/3001/4009#newcode4
chrome/browser/resources/options/autofill_edit_address_overlay.html:4: <form
id="autoFillEditAddressForm">
umm.. why do we need a form here?

http://codereview.chromium.org/3157027/diff/3001/4010
File chrome/browser/resources/options/autofill_edit_address_overlay.js (right):

http://codereview.chromium.org/3157027/diff/3001/4010#newcode40
chrome/browser/resources/options/autofill_edit_address_overlay.js:40: //
TODO(jhawkins): Need to clear input fields?
yea you will.  Just do it in this cl.

[James Hawkins, 2010-08-19 17:58:23]

http://codereview.chromium.org/3157027/diff/3001/4002
File chrome/browser/dom_ui/add_startup_page_handler.h (right):

http://codereview.chromium.org/3157027/diff/3001/4002#newcode10
chrome/browser/dom_ui/add_startup_page_handler.h:10: #include
"base/basictypes.h"
On 2010/08/18 22:44:07, dhg wrote:
> I'm not clear as to why this needed to be moved to the header

For DISALLOW_COPY_AND_ASSIGN().

http://codereview.chromium.org/3157027/diff/3001/4007
File chrome/browser/resources/options/add_startup_page_overlay.js (right):

http://codereview.chromium.org/3157027/diff/3001/4007#newcode129
chrome/browser/resources/options/add_startup_page_overlay.js:129: });
On 2010/08/18 22:44:07, dhg wrote:
> This file should probably just be reverted.

Why?  There's an extra newline, which I removed.

http://codereview.chromium.org/3157027/diff/3001/4009
File chrome/browser/resources/options/autofill_edit_address_overlay.html
(right):

http://codereview.chromium.org/3157027/diff/3001/4009#newcode4
chrome/browser/resources/options/autofill_edit_address_overlay.html:4: <form
id="autoFillEditAddressForm">
On 2010/08/18 22:44:07, dhg wrote:
> umm.. why do we need a form here?

Turns out we don't.  I had to modify the JS to act on the reset button's onclick
instead of using form.onreset.

http://codereview.chromium.org/3157027/diff/3001/4010
File chrome/browser/resources/options/autofill_edit_address_overlay.js (right):

http://codereview.chromium.org/3157027/diff/3001/4010#newcode40
chrome/browser/resources/options/autofill_edit_address_overlay.js:40: //
TODO(jhawkins): Need to clear input fields?
On 2010/08/18 22:44:07, dhg wrote:
> yea you will.  Just do it in this cl.

Done.

[James Hawkins, 2010-08-19 19:49:54]

+csilv

[James Hawkins, 2010-08-19 20:39:39]

ping

[csilv, 2010-08-19 21:06:17]

http://codereview.chromium.org/3157027/diff/8002/10001
File chrome/browser/dom_ui/add_startup_page_handler.cc (right):

http://codereview.chromium.org/3157027/diff/8002/10001#newcode8
chrome/browser/dom_ui/add_startup_page_handler.cc:8: #include "base/singleton.h"
I don't see a reference to base/singleton.h, but maybe i'm just not seeing it..?

http://codereview.chromium.org/3157027/diff/8002/10009
File chrome/browser/resources/options/autofill_edit_address_overlay.html
(right):

http://codereview.chromium.org/3157027/diff/8002/10009#newcode4
chrome/browser/resources/options/autofill_edit_address_overlay.html:4: <label
id="fullNameLabel"><span i18n-content="fullNameLabel"></span><br>
You should be able to safely remove the <br>'s, as 'label' has been defined as a
block element in the .css file.  While that makes this somewhat cosmetic, it
would be more consistent with other panels.

http://codereview.chromium.org/3157027/diff/8002/10010
File chrome/browser/resources/options/autofill_edit_address_overlay.js (right):

http://codereview.chromium.org/3157027/diff/8002/10010#newcode34
chrome/browser/resources/options/autofill_edit_address_overlay.js:34: },
I assume the submit task is going to be implemented in a separate CL?

[James Hawkins, 2010-08-19 22:53:21]

http://codereview.chromium.org/3157027/diff/8002/10001
File chrome/browser/dom_ui/add_startup_page_handler.cc (right):

http://codereview.chromium.org/3157027/diff/8002/10001#newcode8
chrome/browser/dom_ui/add_startup_page_handler.cc:8: #include "base/singleton.h"
On 2010/08/19 21:06:17, csilv wrote:
> I don't see a reference to base/singleton.h, but maybe i'm just not seeing
it..?

Got removed in between uploads by another commit. Removed.

http://codereview.chromium.org/3157027/diff/8002/10009
File chrome/browser/resources/options/autofill_edit_address_overlay.html
(right):

http://codereview.chromium.org/3157027/diff/8002/10009#newcode4
chrome/browser/resources/options/autofill_edit_address_overlay.html:4: <label
id="fullNameLabel"><span i18n-content="fullNameLabel"></span><br>
On 2010/08/19 21:06:17, csilv wrote:
> You should be able to safely remove the <br>'s, as 'label' has been defined as
a
> block element in the .css file.  While that makes this somewhat cosmetic, it
> would be more consistent with other panels.

Cool, thanks. Done.

http://codereview.chromium.org/3157027/diff/8002/10010
File chrome/browser/resources/options/autofill_edit_address_overlay.js (right):

http://codereview.chromium.org/3157027/diff/8002/10010#newcode34
chrome/browser/resources/options/autofill_edit_address_overlay.js:34: },
On 2010/08/19 21:06:17, csilv wrote:
> I assume the submit task is going to be implemented in a separate CL?

Indeed, wanted to keep it small.

[csilv, 2010-08-20 00:07:55]

LGTM