Introduce a test for ath3k hardware.

Introduce a test for ath3k hardware.

Change-Id: I42ca375473b0d36cde21d626495878b2d741d914
BUG=chrome-os-partner:273
TEST=see below

Build a test image and install it on an Andretti machine.
While in chroot on the development machine run the test as
follows:

./run_remote_tests.sh --board=x86-generic --remote=172.22.75.149 hardware_Ath3k

observe the results:

>>> Test results:
-----------------------------------
hardware_Ath3k                PASS
hardware_Ath3k/hardware_Ath3k PASS
-----------------------------------
Total PASS: 2/2 (100%)

[petkov, 2010-08-18 21:27:01]

Did you mean petkov@chromium.org?

On Wed, Aug 18, 2010 at 2:22 PM, <vbendeb@chromium.org> wrote:

> Reviewers: darin,
>
> Description:
> Introduce a test for ath3k hardware.
>
> Change-Id: I42ca375473b0d36cde21d626495878b2d741d914
> BUG=chrome-os-partner:273
> TEST=see below
>
> Build a test image and install it on an Andretti machine.
> While in chroot on the development machine run the test as
> follows:
>
> ./run_remote_tests.sh --board=x86-generic --remote=172.22.75.149
> hardware_Ath3k
>
> observe the results:
>
>  Test results:
>>>>
>>> -----------------------------------
> hardware_Ath3k                PASS
> hardware_Ath3k/hardware_Ath3k PASS
> -----------------------------------
> Total PASS: 2/2 (100%)
>
>
>
> Please review this at http://codereview.chromium.org/3157019/show
>
> SVN Base: http://src.chromium.org/git/autotest.git
>
> Affected files:
>  A client/site_tests/hardware_Ath3k/control
>  A client/site_tests/hardware_Ath3k/hardware_Ath3k.py
>
>
> Index: client/site_tests/hardware_Ath3k/control
> diff --git a/client/site_tests/hardware_Ath3k/control
> b/client/site_tests/hardware_Ath3k/control
> new file mode 100644
> index
>
0000000000000000000000000000000000000000..d182a3e45e9be25f77536a3c4079635b0b95c98d
> --- /dev/null
> +++ b/client/site_tests/hardware_Ath3k/control
> @@ -0,0 +1,19 @@
> +# Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
> +# Use of this source code is governed by a BSD-style license that can be
> +# found in the LICENSE file.
> +
> +NAME = 'hardware_Ath3k'
> +AUTHOR = 'The Chromium OS Authors'
> +PURPOSE = 'Verify Ath3k device and its driver presence.'
> +CRITERIA = 'Fails if usb device 0cf3:3002 or ath3k module is missing.'
> +TIME='SHORT'
> +TEST_CATEGORY = 'Performance'
> +TEST_CLASS = 'Functional'
> +TEST_TYPE = 'client'
> +
> +DOC = """
> +Looks first for usb device associated with the Ath3k Bluetooth
> controllerand
> +then for its driver module (Ath3k)
> +"""
> +
> +job.run_test('hardware_Ath3k')
> Index: client/site_tests/hardware_Ath3k/hardware_Ath3k.py
> diff --git a/client/site_tests/hardware_Ath3k/hardware_Ath3k.py
> b/client/site_tests/hardware_Ath3k/hardware_Ath3k.py
> new file mode 100644
> index
>
0000000000000000000000000000000000000000..5abf87c4d50907574e499a6c64523ed2e128392d
> --- /dev/null
> +++ b/client/site_tests/hardware_Ath3k/hardware_Ath3k.py
> @@ -0,0 +1,35 @@
> +# Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
> +# Use of this source code is governed by a BSD-style license that can be
> +# found in the LICENSE file.
> +
> +import logging
> +
> +from autotest_lib.client.bin import test, utils
> +from autotest_lib.client.common_lib import error
> +
> +
> +def usb_device_present(vendor_device):
> +    '''Check if lsusb reports certain vendor/device ID combination.
> +
> +    This should eventually be added to autotest_lib.client.bin.utils.
> +    '''
> +
> +    match_string = ' %s ' % vendor_device.lower()
> +    usb_devices = utils.system_output('/usr/sbin/lsusb').splitlines()
> +    for usb_device in usb_devices:
> +        if match_string in usb_device:
> +            return True
> +    return False
> +
> +
> +class hardware_Ath3k(test.test):
> +    version = 1
> +
> +    def run_once(self):
> +        device = '0cf3:3002'
> +        module= 'ath3k'
> +        if not usb_device_present(device):
> +            raise error.TestFail('usb device %s not found' % device)
> +
> +        if not utils.module_is_loaded(module):
> +            raise error.TestFail('driver module %s not loaded' % module)
>
>
>

[vb, 2010-08-18 21:36:56]

Now sending to the proper reviewer.

[petkov, 2010-08-18 21:42:50]

Are you planning to add this test to any suites?

http://codereview.chromium.org/3157019/diff/2001/3001
File client/site_tests/hardware_Ath3k/control (right):

http://codereview.chromium.org/3157019/diff/2001/3001#newcode8
client/site_tests/hardware_Ath3k/control:8: CRITERIA = 'Fails if usb device
0cf3:3002 or ath3k module is missing.'
maybe capitalize USB -- here and below.

http://codereview.chromium.org/3157019/diff/2001/3001#newcode15
client/site_tests/hardware_Ath3k/control:15: Looks first for usb device
associated with the Ath3k Bluetooth controllerand
space before and

http://codereview.chromium.org/3157019/diff/2001/3001#newcode16
client/site_tests/hardware_Ath3k/control:16: then for its driver module (Ath3k)
period at the end.

http://codereview.chromium.org/3157019/diff/2001/3002
File client/site_tests/hardware_Ath3k/hardware_Ath3k.py (right):

http://codereview.chromium.org/3157019/diff/2001/3002#newcode17
client/site_tests/hardware_Ath3k/hardware_Ath3k.py:17: match_string = ' %s ' %
vendor_device.lower()
why don't you use lsusb -d <vendor>:<device>?
it returns 0 on success, 1 on failure (and system_output will throw an exception
by default, I think).

http://codereview.chromium.org/3157019/diff/2001/3002#newcode30
client/site_tests/hardware_Ath3k/hardware_Ath3k.py:30: module= 'ath3k'
space before =

[vb, 2010-08-18 22:17:23]

Darin, thank you for a quick review. I addressed your comments, please look
again.

As for adding this to a suite - I was going to discuss this
with the test people separately. Actually, one other step is
missing - adding this to the autotest ebuild so that the
repo workflow has this test included.

This will be a separate CL.

http://codereview.chromium.org/3157019/diff/2001/3001
File client/site_tests/hardware_Ath3k/control (right):

http://codereview.chromium.org/3157019/diff/2001/3001#newcode8
client/site_tests/hardware_Ath3k/control:8: CRITERIA = 'Fails if usb device
0cf3:3002 or ath3k module is missing.'
On 2010/08/18 21:42:50, petkov wrote:
> maybe capitalize USB -- here and below.
> 

Done.

http://codereview.chromium.org/3157019/diff/2001/3001#newcode15
client/site_tests/hardware_Ath3k/control:15: Looks first for usb device
associated with the Ath3k Bluetooth controllerand
On 2010/08/18 21:42:50, petkov wrote:
> space before and

Done.

http://codereview.chromium.org/3157019/diff/2001/3001#newcode16
client/site_tests/hardware_Ath3k/control:16: then for its driver module (Ath3k)
On 2010/08/18 21:42:50, petkov wrote:
> period at the end.

Done.

http://codereview.chromium.org/3157019/diff/2001/3002
File client/site_tests/hardware_Ath3k/hardware_Ath3k.py (right):

http://codereview.chromium.org/3157019/diff/2001/3002#newcode17
client/site_tests/hardware_Ath3k/hardware_Ath3k.py:17: match_string = ' %s ' %
vendor_device.lower()
On 2010/08/18 21:42:50, petkov wrote:
> why don't you use lsusb -d <vendor>:<device>?
> it returns 0 on success, 1 on failure (and system_output will throw an
exception
> by default, I think).
> 

changed to use utils.run() which allows to see exit status of the command.

http://codereview.chromium.org/3157019/diff/2001/3002#newcode30
client/site_tests/hardware_Ath3k/hardware_Ath3k.py:30: module= 'ath3k'
On 2010/08/18 21:42:50, petkov wrote:
> space before =
> 

Done.

[petkov, 2010-08-18 22:29:50]

LGTM w/ a suggestion.

http://codereview.chromium.org/3157019/diff/10001/11002
File client/site_tests/hardware_Ath3k/hardware_Ath3k.py (right):

http://codereview.chromium.org/3157019/diff/10001/11002#newcode18
client/site_tests/hardware_Ath3k/hardware_Ath3k.py:18: ).exit_status == 0
Probably a personal preference so feel free to ignore but... I don't like this
closing parenthesis on a separate line. Maybe assign the command to a variable
and then on one line:

return utils.run(command).exit_status == 0

[vb, 2010-08-18 22:40:00]

retested, about to submit.

http://codereview.chromium.org/3157019/diff/10001/11002
File client/site_tests/hardware_Ath3k/hardware_Ath3k.py (right):

http://codereview.chromium.org/3157019/diff/10001/11002#newcode18
client/site_tests/hardware_Ath3k/hardware_Ath3k.py:18: ).exit_status == 0
On 2010/08/18 22:29:50, petkov wrote:
> Probably a personal preference so feel free to ignore but... I don't like this
> closing parenthesis on a separate line. Maybe assign the command to a variable
> and then on one line:
> 
> return utils.run(command).exit_status == 0
> 

Done.