Issue 3157018: Only showing notification when a restart is needed. Partial fix to 5168.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3157018: Only showing notification when a restart is needed. Partial fix to 5168. (Closed)

Created:
10 years, 4 months ago by Sean Parent

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, DaveMoore

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Only showing notification when a restart is needed. Partial fix to 5168. BUG=chromium-os:5168 TEST=Manual - use devserver to install update and verify notification appears to restart after update is installed with no other notifications. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56616 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56899

Patch Set 1 #

Patch Set 2 : . #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -49 lines)			Patch
	M	chrome/browser/chromeos/update_observer.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	chrome/browser/chromeos/update_observer.cc	View	1	1 chunk	+9 lines, -48 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

CrOS dbg's browser_tests started timing out here: http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20(ChromiumOS%20dbg)/builds/594 All the other patches look innocent, so ...

10 years, 4 months ago (2010-08-19 05:26:43 UTC) #3

Sean Parent

Sorry for the trouble - it was a bad test. I'll resubmit shortly.

10 years, 4 months ago (2010-08-19 20:36:51 UTC) #5

Sean Parent

10 years, 4 months ago (2010-08-19 22:16:56 UTC) #6

I take that back - I'm not able to replicate the problem locally and
the relevant test to the CL  (browser/chromeos/update_browsertest.cc) is
fine as is. I've asked Zel to try and replicate the problem on his machine.
Can anyone determine from the log what test was actually executing when it
hung?

Thanks,
Sean

On Thu, Aug 19, 2010 at 1:36 PM, Sean Parent <seanparent@chromium.org>wrote:

> Sorry for the trouble - it was a bad test. I'll resubmit shortly.

Expand Messages | Collapse Messages