Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: third_party/libevent/README.google

Issue 3157: Build libevent on Mac (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/net.xcodeproj/project.pbxproj ('k') | third_party/libevent/SConscript » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libevent/README.google
===================================================================
--- third_party/libevent/README.google (revision 2378)
+++ third_party/libevent/README.google (working copy)
@@ -1,19 +1,20 @@
-This contains a copy of libevent-1.4.7-stable, initially
-for use on Linux, but also perhaps on BSD / Solaris / Mac.
+This contains a copy of libevent-1.4.7-stable for use on Linux and Mac
Rather than use libevent's own build system, we just build a Chrome
-static library using SConstruct.
+static library using SConscript
Changes from upstream:
-1) add config.h from a run of configure on a Linux development box.
-2) add SConstruct
+1) add linux/config.h from a run of configure on a Linux development box.
+2) add SConscript and libevent.xcodeproj
3) quotes.patch is applied to allow libevent to be used without
being installed (alternative is adding crazy -I arguments to the commandline)
4) The directories WIN32-Code and WIN32-Prj are not included
-SConstruct does not include a few files that don't build on Linux:
+SConscript does not include a few files that don't build on Linux:
devpoll.c, evport.c, kqueue.c
+libevent.xcodeproj does not include a few files that don't build on the Mac:
+ devpoll.c, epoll.c, epoll_sub.c, evport.c
-TODO: currently we -I the source directory, which exposes config.h, which
-is dangerous. We should probably add an include directory of symlinks
-back to the real .h files, or something.
+TODO: currently we -I the source directory, which exposes event-config.h, which
+is dangerous as this file was generated for Linux and is not entirely correct on
+other platforms.
« no previous file with comments | « net/net.xcodeproj/project.pbxproj ('k') | third_party/libevent/SConscript » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698