Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: tools/valgrind/tsan_analyze.py

Issue 3156050: tsan_analyze.py now assumes that all ThreadSanitizer reports contain VIM fold... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/tsan_analyze.py
===================================================================
--- tools/valgrind/tsan_analyze.py (revision 57513)
+++ tools/valgrind/tsan_analyze.py (working copy)
@@ -83,9 +83,7 @@
TheAddressTable.Add(stack_trace_line.binary, stack_trace_line.address)
self.stack_trace_line_ = stack_trace_line
- # TODO(glider): merge Read*Section once TSan is fixed to print {{{ and }}}
- # around all reports.
- def ReadRaceSection(self):
+ def ReadSection(self):
result = [self.line_]
if re.search("{{{", self.line_):
while not re.search('}}}', self.line_):
@@ -96,18 +94,6 @@
result.append(self.stack_trace_line_)
return result
- def ReadWarningSection(self):
- result = [self.line_]
- self.ReadLine()
- while TsanAnalyzer.TSAN_WARNING_LINE_RE.match(self.line_):
- self.ReadLine()
- if self.stack_trace_line_ is None:
- result.append(self.line_)
- else:
- result.append(self.stack_trace_line_)
- return result
-
-
def ParseReportFile(self, filename):
self.cur_fd_ = open(filename, 'r')
@@ -119,16 +105,14 @@
tmp = []
while re.search(TsanAnalyzer.THREAD_CREATION_STR, self.line_):
- # TODO(glider): that's not really a race section but rather an {{{...}}}
- # but use this wrong name to quick-fix the script.
- tmp.extend(self.ReadRaceSection())
+ tmp.extend(self.ReadSection())
self.ReadLine()
if re.search(TsanAnalyzer.TSAN_RACE_DESCRIPTION, self.line_):
- tmp.extend(self.ReadRaceSection())
+ tmp.extend(self.ReadSection())
self.reports.append(tmp)
if (re.search(TsanAnalyzer.TSAN_WARNING_DESCRIPTION, self.line_) and
not common.IsWindows()): # workaround for http://crbug.com/53198
- tmp.extend(self.ReadWarningSection())
+ tmp.extend(self.ReadSection())
self.reports.append(tmp)
match = re.search(" used_suppression:\s+([0-9]+)\s(.*)", self.line_)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698