modify factory_Wipe to fit into new flow (with factory_Verify)

modify factory_Wipe to fit into new flow (with factory_Verify)

The factory_Wipe now only depends on the factory_Verify test,
which can be assigned via unique_name in suite_Factory/test_list.
Ref: http://codereview.chromium.org/3180022/show

BUG=chrome-os-partner:827
TEST=manual

Change-Id: Icc9f84ee7aa0842de8075b4c94c79e0c9a7026bd

[Tammo Spalink, 2010-08-25 03:26:01]

http://codereview.chromium.org/3156047/diff/1/2
File client/bin/factory.py (right):

http://codereview.chromium.org/3156047/diff/1/2#newcode40
client/bin/factory.py:40: def check_ready_for_finalize(need_verify, test_list,
status_file_path):
not sure i understand why this is being defined in this file

[Hung-Te, 2010-08-25 03:48:10]

Right now only factory_Wipe needs that. But in the future if we put more stuff
in "final" stage, they will all need to check; that's why I put it as a global
factory utility function.

[Tammo Spalink, 2010-08-25 04:03:42]

http://codereview.chromium.org/3156047/diff/1/2
File client/bin/factory.py (right):

http://codereview.chromium.org/3156047/diff/1/2#newcode32
client/bin/factory.py:32: FINAL_VERIFY_TEST_NAME = 'factory_Verify'
how about FINAL_VERIFICATION_TEST_UNIQUE_NAME?

http://codereview.chromium.org/3156047/diff/1/2#newcode45
client/bin/factory.py:45: if status_map.lookup_status(xtest) != PASSED:
if we add a lookup_status_by_unique_name() to StatusMap, it would seem like we
mostly do not need this function

it just seems a bit unpleasant to hide a whole StatusMap creation inside a
"check_xxx" function

[Hung-Te, 2010-08-25 04:51:21]

http://codereview.chromium.org/3156047/diff/1/2
File client/bin/factory.py (right):

http://codereview.chromium.org/3156047/diff/1/2#newcode32
client/bin/factory.py:32: FINAL_VERIFY_TEST_NAME = 'factory_Verify'
On 2010/08/25 04:03:42, Tammo Spalink wrote:
> how about FINAL_VERIFICATION_TEST_UNIQUE_NAME?

Done.

http://codereview.chromium.org/3156047/diff/1/2#newcode45
client/bin/factory.py:45: if status_map.lookup_status(xtest) != PASSED:
Since there's only one (wipe) test needs this now, I'd agree to change as you
suggested.