Attempting to debug the IE8 chrome frame random failures by tracing out the l...

Attempting to debug the IE8 chrome frame random failures by tracing out the last error
code from the net::TestServer::WaitToFinish helper function.

TBR=amit


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56817

[amit, 2010-08-20 15:58:06]

ok

On Thu, Aug 19, 2010 at 10:11 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Attempting to debug the IE8 chrome frame random failures by tracing out the
> last
> error
> code from the net::TestServer::WaitToFinish helper function.
>
> TBR=amit
>
>
> Please review this at http://codereview.chromium.org/3156039/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/http_server.cc
>
>
> Index: chrome_frame/test/http_server.cc
> ===================================================================
> --- chrome_frame/test/http_server.cc    (revision 56679)
> +++ chrome_frame/test/http_server.cc    (working copy)
> @@ -64,7 +64,11 @@
>  }
>
>  bool ChromeFrameHTTPServer::WaitToFinish(int milliseconds) {
> -  return test_server_.WaitToFinish(milliseconds);
> +  bool ret = test_server_.WaitToFinish(milliseconds);
> +  if (!ret) {
> +    LOG(ERROR) << "WaitToFinish failed with error:" << ::GetLastError();
> +  }
> +  return ret;
>  }
>
>  // TODO(phajdan.jr): Change wchar_t* to std::string& and fix callers.
>
>
>