Issue 3156034: Remove the default values and add a comprehensible error message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3156034: Remove the default values and add a comprehensible error message. (Closed)

Created:
10 years, 4 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, nsylvain

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Remove the default values and add a comprehensible error message. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56699

Patch Set 2 : addressed review comments #

Patch Set 3 : Change wording #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -13 lines)			Patch
	M	gcl.py	View	1 2	5 chunks	+11 lines, -13 lines	0 comments	Download
	M	tests/gcl_unittest.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nsylvain

http://codereview.chromium.org/3156034/diff/1/2 File gcl.py (right): http://codereview.chromium.org/3156034/diff/1/2#newcode564 gcl.py:564: ('Please add a %s file with CODE_REVIEW_SERVER: codereview.appspot.com ' ...

10 years, 4 months ago (2010-08-19 14:56:03 UTC) #2

LGTM. -s would work for real , right?