Issue 3155025: build_image: make sure the factory_image size is propagated

Issue 3155025: build_image: make sure the factory_image size is propagated (Closed)

Created:
10 years, 4 months ago by Will Drewry

Modified:
9 years, 7 months ago

Reviewers:
Nick Sanders, adlr

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://src.chromium.org/git/crosutils.git

Visibility:
Public.

Description

build_image: make sure the factory_image size is propagated Verified rootfs-based factory installers fail because the ROOT_SIZE_BYTES is updated, but the information is not propagated to the boot.desc which cros_make_image_bootable uses. The result is that mod_image_for_test incorrectly appends the rootfs hash even though it is correctly computed. Random note: build_kernel_image uses dumpe2fs to compute the size, but cros_make_image_bootable uses the supplied size. These shouldn't diverge though the partition size should accomodate the addition of the hashes. TODO(wad) Add checking of sizes in cros_make_image_bootable TEST=x86-generic build image with --enable_rootfs_verification and --factory_install; then put in a machine and it no longer spewed dm-verity hash errors and the root hash checked successfully! BUG=chromium-os:5100

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -15 lines)			Patch
	M	build_image	View	1 2 3	4 chunks	+15 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM w/ 2 nits http://codereview.chromium.org/3155025/diff/1/2 File build_image (right): http://codereview.chromium.org/3155025/diff/1/2#newcode53 build_image:53: "rootfs filesystem size in MBs." ...

10 years, 4 months ago (2010-08-17 16:44:07 UTC) #2

Will Drewry

Replaced incorrect MB usage everywhere it stood out. PTAL! On Tue, Aug 17, 2010 at ...

10 years, 4 months ago (2010-08-17 17:37:18 UTC) #3

Will Drewry

10 years, 4 months ago (2010-08-17 19:01:34 UTC) #4

I ignored the lgtm. nits fixed. I'll push.
On 2010/08/17 17:37:18, Will Drewry wrote:
> Replaced incorrect MB usage everywhere it stood out.  PTAL!
> 
> On Tue, Aug 17, 2010 at 11:44 AM,  <mailto:adlr@chromium.org> wrote:
> > LGTM w/ 2 nits
> >
> >
> > http://codereview.chromium.org/3155025/diff/1/2
> > File build_image (right):
> >
> > http://codereview.chromium.org/3155025/diff/1/2#newcode53
> > build_image:53: "rootfs filesystem size in MBs."
> > s/MB/MiB/
> >
> > http://codereview.chromium.org/3155025/diff/1/2#newcode626
> > build_image:626: info "Fixing the rootfs size at 300m for the factory
> > installer"
> > s/300m/300 MiB/
> >
> > http://codereview.chromium.org/3155025/show
> >
>

Expand Messages | Collapse Messages