Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 3155024: Fix gclient_utils_test and disable gclient_scm_test. (Closed)

Created:
10 years, 4 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
chase
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Fix gclient_utils_test and disable gclient_scm_test. gclient_scm_test is really flaky and is a pain to maintain. gclient_scm.py coverage is good enough with gclient_smokte_test. TBR=chase Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M PRESUBMIT.py View 1 chunk +2 lines, -1 line 0 comments Download
M tests/gclient_utils_test.py View 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
10 years, 4 months ago (2010-08-17 15:10:49 UTC) #1
chase
10 years, 4 months ago (2010-08-17 22:55:22 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698