Issue 3153037: Use collector for preparse data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3153037: Use collector for preparse data. (Closed)

Created:
10 years, 4 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Use collector for preparse data. This is in preparation of adding more data to the preparse record. Using a collector instead of a list avoids copying data when the backing store grows.

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -27 lines)			Patch
	M	src/parser.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	src/parser.cc	View		8 chunks	+35 lines, -27 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 4 months ago (2010-08-24 14:25:54 UTC) #2

LGTM

http://codereview.chromium.org/3153037/diff/1/2
File src/parser.cc (right):

http://codereview.chromium.org/3153037/diff/1/2#newcode965
src/parser.cc:965: : has_error_(false), store_(ScriptDataImpl::kHeaderSize) {
Four space indent.

Expand Messages | Collapse Messages