Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3153034: reland 57093: dom-ui options: record user metrics for pref changes.... (Closed)

Created:
10 years, 4 months ago by csilv
Modified:
9 years, 7 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

reland 57093: dom-ui options: record user metrics for pref changes. BUG=52520 TEST=Verify metrics are saved when changing options in dom-ui options window (--enable-tabbed-options). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57200

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -70 lines) Patch
M chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc View 1 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/advanced_options_handler.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/browser_options_handler.cc View 1 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/core_options_handler.h View 1 2 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/core_options_handler.cc View 1 7 chunks +35 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/advanced_options.html View 1 5 chunks +24 lines, -19 lines 0 comments Download
M chrome/browser/resources/options/advanced_options.js View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/autofill_options.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 2 chunks +18 lines, -12 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/content_settings.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options/font_settings_overlay.html View 1 4 chunks +14 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/personal_options.html View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/personal_options.js View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/pref_ui.js View 1 10 chunks +37 lines, -8 lines 0 comments Download
M chrome/browser/resources/options/preferences.js View 1 4 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
csilv
+stuartmorgan for review. This will be a relanding of: http://codereview.chromium.org/3119038/show Fixed a merge bug that ...
10 years, 4 months ago (2010-08-24 17:12:19 UTC) #1
stuartmorgan
10 years, 4 months ago (2010-08-24 17:14:22 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698