Gateway Location Provider

Gateway Location Provider
Location provider using the MAC address of a router the user is connected to via Ethernet to find a position fix.
BUG=NONE
TEST=Unit test

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57052

[joth, 2010-08-23 11:24:59]

LGTM, few small comments.

The repetition of {Wifi, Radio, Gateway} is starting to get a bit cumbersome,
but as we don't expect this set to grow further, it's not obvious there's a
clear benefit in factoring this out to generalize & remove the duplication.

http://codereview.chromium.org/3153031/diff/2001/3001
File chrome/browser/geolocation/device_data_provider.h (right):

http://codereview.chromium.org/3153031/diff/2001/3001#newcode188
chrome/browser/geolocation/device_data_provider.h:188: struct RouterDataLess :
public std::less<RouterData> {
could you make another CL to remove this inheritance from all three of these
classes?
(can probably remove <functional> from the includes too)

http://codereview.chromium.org/3153031/diff/2001/3001#newcode210
chrome/browser/geolocation/device_data_provider.h:210: }
fyi this is O(nlogn). as both sets are ordered, we can do this comparison in
O(n).
- use two iterators and advance both in step.

http://codereview.chromium.org/3153031/diff/2001/3003
File chrome/browser/geolocation/network_location_provider.cc (right):

http://codereview.chromium.org/3153031/diff/2001/3003#newcode324
chrome/browser/geolocation/network_location_provider.cc:324:
DCHECK_EQ(!!gateway_data_provider_, !!radio_data_provider_);
compare gateway with wifi here (as wifi is the thing we return, to avoid the
transitive dependency through the DCHECKs)

http://codereview.chromium.org/3153031/diff/2001/3005
File chrome/browser/geolocation/network_location_provider_unittest.cc (right):

http://codereview.chromium.org/3153031/diff/2001/3005#newcode287
chrome/browser/geolocation/network_location_provider_unittest.cc:287:
EXPECT_EQ(expected->radio_signal_strength, actual->radio_signal_strength)
overlength

[allanwoj, 2010-08-23 14:07:17]

http://codereview.chromium.org/3153031/diff/2001/3001
File chrome/browser/geolocation/device_data_provider.h (right):

http://codereview.chromium.org/3153031/diff/2001/3001#newcode188
chrome/browser/geolocation/device_data_provider.h:188: struct RouterDataLess :
public std::less<RouterData> {
On 2010/08/23 11:24:59, joth wrote:
> could you make another CL to remove this inheritance from all three of these
> classes?
> (can probably remove <functional> from the includes too)
Yep, will do.

http://codereview.chromium.org/3153031/diff/2001/3001#newcode210
chrome/browser/geolocation/device_data_provider.h:210: }
On 2010/08/23 11:24:59, joth wrote:
> fyi this is O(nlogn). as both sets are ordered, we can do this comparison in
> O(n).
> - use two iterators and advance both in step.
> 

Done.

http://codereview.chromium.org/3153031/diff/2001/3005
File chrome/browser/geolocation/network_location_provider_unittest.cc (right):

http://codereview.chromium.org/3153031/diff/2001/3005#newcode287
chrome/browser/geolocation/network_location_provider_unittest.cc:287:
EXPECT_EQ(expected->radio_signal_strength, actual->radio_signal_strength)
On 2010/08/23 11:24:59, joth wrote:
> overlength

Done.