Issue 3153030: Fix typo in TestURLFetcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3153030: Fix typo in TestURLFetcher (Closed)

Created:
10 years, 4 months ago by ukai

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, Timur Iskhodzhanov

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Visibility:
Public.

Description

Fix typo in TestURLFetcher BUG=52826, 52562 TEST=valgrind pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56861

Patch Set 1 #

Patch Set 2 : rm suppression #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -8 lines)			Patch
	M	chrome/common/net/test_url_fetcher_factory.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

LGTM! <kidding>I didn't know Valgrind can even find typos</kidding> Missing the override keyword in C++...

10 years, 4 months ago (2010-08-20 10:43:31 UTC) #2

Lei Zhang

10 years, 4 months ago (2010-08-21 01:17:28 UTC) #3

But the memory errors came back after you removed this suppression. =( I'm going
to put it back.

Expand Messages | Collapse Messages