Issue 3152042: Simplified the full codegens by removing the Expression::kTestValue...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3152042: Simplified the full codegens by removing the Expression::kTestValue... (Closed)

Created:
10 years, 4 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium), Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Simplified the full codegens by removing the Expression::kTestValue and Expression::kValueTest. At the same time, prepare the code for keeping track of fall through labels to avoid unnecessary jumps. Committed: http://code.google.com/p/v8/source/detail?r=5320

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+214 lines, -948 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	25 chunks	+49 lines, -237 lines	0 comments	Download
M	src/ast.h	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	src/full-codegen.h	View	3 chunks	+13 lines, -39 lines	0 comments	Download
M	src/full-codegen.cc	View	4 chunks	+74 lines, -26 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	28 chunks	+39 lines, -321 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	27 chunks	+38 lines, -318 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

10 years, 4 months ago (2010-08-23 12:55:44 UTC) #3

On 2010/08/23 12:51:22, Mads Ager wrote:
> LGTM
LGTM, as discussed offline, maybe we should move the implementation of the
remaining Visit functions in full-codegen away from the header file (in another
change)

Expand Messages | Collapse Messages