Issue 3152036: Widen suppression for bug 50936, suppress leaks in chrome/browser/host_conten...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3152036: Widen suppression for bug 50936, suppress leaks in chrome/browser/host_conten... (Closed)

Created:
10 years, 4 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Widen suppression for bug 50936, suppress leaks in chrome/browser/host_content_settings_map_unittest.cc BUG=50936, 52828 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56838

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		2 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 4 months ago (2010-08-20 09:55:56 UTC) #2

LGTM

On Fri, Aug 20, 2010 at 1:55 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Widen suppression for bug 50936, suppress leaks in
> chrome/browser/host_content_settings_map_unittest.cc
> BUG=50936,52828
>
> Please review this at http://codereview.chromium.org/3152036/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> ===================================================================
> --- tools/valgrind/memcheck/suppressions.txt    (revision 56835)
> +++ tools/valgrind/memcheck/suppressions.txt    (working copy)
> @@ -3748,8 +3748,6 @@
>    ...
>
>
 fun:_ZN3IPC16MessageWithReplyI6Tuple2IiiE6Tuple1IRbEE18DispatchDelayReplyI18AutomationProviderMS8_FviiPNS_7MessageEEEEbPKS9_PT_T0_
>    fun:_ZN18AutomationProvider17OnMessageReceivedERKN3IPC7MessageE
> -   fun:_ZN3IPC12ChannelProxy7Context17OnDispatchMessageERKNS_7MessageE
> -   fun:_ZN3IPC11SyncChannel20ReceivedSyncMsgQueue16DispatchMessagesEv
>  }
>  {
>    bug_50968
> @@ -4156,3 +4154,14 @@
>    fun:_ZN14TestingProfile20CreateRequestContextEv
>    fun:_ZN20GoogleURLTrackerTest20CreateRequestContextEv
>  }
> +{
> +   bug_52828
> +   Memcheck:Leak
> +   fun:_Znw*
> +   ...
> +   fun:_ZN4base10JSONReader10BuildValueEb
> +   fun:_ZN4base10JSONReader11JsonToValueERKSsbb
> +   fun:_ZN4base10JSONReader18ReadAndReturnErrorERKSsbPiPSs
> +   fun:_ZN4base10JSONReader4ReadERKSsb
> +
> fun:_ZN81_GLOBAL__N_chrome_browser_host_content_settings_map_unittest.cc*
> +}
>
>
>

Expand Messages | Collapse Messages