Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 3152020: Adding a tool to embed a URL into the BIOS bitmaps. (Closed)

Created:
10 years, 4 months ago by Bill Richardson
Modified:
9 years, 6 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Base URL:
http://src.chromium.org/git/vboot_reference.git
Visibility:
Public.

Description

Adding a tool to embed a URL into the BIOS bitmaps. BUG=chrome-os-partner:726

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -0 lines) Patch
A scripts/bitmaps/make_bmp_images.sh View 1 chunk +106 lines, -0 lines 1 comment Download
A scripts/bitmaps/originals/BlankBmp.gif View Binary file 0 comments Download
A scripts/bitmaps/originals/DeveloperBmp.gif View Binary file 0 comments Download
A scripts/bitmaps/originals/DeveloperBmp.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A scripts/bitmaps/originals/RecoveryBmp.gif View Binary file 0 comments Download
A scripts/bitmaps/originals/RecoveryBmp.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A scripts/bitmaps/originals/RecoveryMissingOSBmp.gif View Binary file 0 comments Download
A scripts/bitmaps/originals/RecoveryMissingOSBmp.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A scripts/bitmaps/originals/RecoveryNoOSBmp.gif View Binary file 0 comments Download
A scripts/bitmaps/originals/RecoveryNoOSBmp.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bill Richardson
10 years, 4 months ago (2010-08-14 01:06:50 UTC) #1
Randall Spangler
10 years, 4 months ago (2010-08-16 15:45:56 UTC) #2
LGTM

http://codereview.chromium.org/3152020/diff/1/2
File scripts/bitmaps/make_bmp_images.sh (right):

http://codereview.chromium.org/3152020/diff/1/2#newcode103
scripts/bitmaps/make_bmp_images.sh:103: # Do it.
(process all files)

Powered by Google App Engine
This is Rietveld 408576698